worker: move terminate callback to end-of-life #58528
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a callback to worker.terminate() has been deprecated for about six years now. It's time to remove it.
jasnell
commented
May 31, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58528 +/- ##
=======================================
Coverage 90.21% 90.22%
=======================================
Files 635 635
Lines 187580 187580
Branches 36853 36851 -2
=======================================
+ Hits 169231 169248 +17
+ Misses 11108 11107 -1
+ Partials 7241 7225 -16
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
May 31, 2025
anonrig
approved these changes
May 31, 2025
This comment was marked as outdated.
This comment was marked as outdated.
targos
approved these changes
Jun 1, 2025
jasnell
commented
Jun 1, 2025
Commit Queue failed- Loading data for nodejs/node/pull/58528 ✔ Done loading data for nodejs/node/pull/58528 ----------------------------------- PR info ------------------------------------ Title worker: move terminate callback to end-of-life (#58528) Author James M Snell <jasnell@gmail.com> (@jasnell) Branch jasnell:jasnell/worker-terminate-callback-eof -> nodejs:main Labels semver-major, author ready, worker, needs-ci, commit-queue-squash Commits 3 - worker: move terminate callback to end-of-life - Update doc/api/deprecations.md - Update test/parallel/test-worker-nexttick-terminate.js Committers 2 - James M Snell <jasnell@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/58528 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58528 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - worker: move terminate callback to end-of-life ⚠ - Update doc/api/deprecations.md ⚠ - Update test/parallel/test-worker-nexttick-terminate.js ℹ This PR was created on Sat, 31 May 2025 16:27:51 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58528#pullrequestreview-2884377109 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/58528#pullrequestreview-2884429441 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/58528#pullrequestreview-2885251569 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-06-01T15:57:47Z: https://ci.nodejs.org/job/node-test-pull-request/67231/ - Querying data for job/node-test-pull-request/67231/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/15397791041 |
jasnell
added a commit
that referenced
this pull request
Jun 2, 2025
Passing a callback to worker.terminate() has been deprecated for about six years now. It's time to remove it. PR-URL: #58528 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in 411cc42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a callback to worker.terminate() has been deprecated for about six years now. It's time to remove it.